On Mon, Jun 15, 2015 at 10:47:26AM -0500, Peter E. Berger wrote: > From: "Peter E. Berger" <pberger@xxxxxxxxxxx> > > The io_ti driver fails to download firmware to Edgeport > devices such as the EP/416, even when the on-disk firmware image > (/lib/firmware/edgeport/down3.bin) is more current than the version > on the EP/416. The current download code is broken in a few ways. > Notably it mis-uses global variables OperationalMajorVersion and > OperationalMinorVersion (reading their values before they've been > properly initialized and subsequently initializing them multiple times > without synchronization). This patch drops the global variables and > replaces the redundant calls to request_firmware()/release_firmware() > in download_fw() with a single call pair in edge_startup(); the firmware > image pointer is then passed to download_fw() and build_i2c_fw_hdr(). > > Signed-off-by: Peter E. Berger <pberger@xxxxxxxxxxx> You should only need this one and the heartbeat patch (on top of the timeout fix); simply merge the later incremental fixes to these patches as needed and I'll take a look at the resulting v6. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
