[PATCH v5 05/10] USB: io_ti: Add comment describing the unused firmware build_number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Peter E. Berger" <pberger@xxxxxxxxxxx>

The firmware has a "build_number" field, though it is apparently unused
(according to observations of the three firmware images I have seen and
confirmed by Digi Tech Support).  This comment describes its structure,
in case it is populated in a future release.

Signed-off-by: Peter E. Berger <pberger@xxxxxxxxxxx>
---
 drivers/usb/serial/io_ti.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index ad93280..98bfd34 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -2386,9 +2386,15 @@ static int edge_startup(struct usb_serial *serial)
 		return err;
 	}
 
+	/*
+	 * If the on-board firmware version is newer, download_fw()
+	 * will retain it and revise edge_serial->fw_version.  The
+	 * firmware also includes an le16 "build_number" at data+2, but
+	 * it has been set to 0 in all three of the images I have seen,
+	 * and Digi Tech Support suggests that it is safe to ignore it.
+	 */
 	fw_major_version = fw->data[0];
 	fw_minor_version = fw->data[1];
-	/* If on-board fw is newer, download_fw() will revise "fw_version" */
 	edge_serial->fw_version = (fw_major_version << 8) + fw_minor_version;
 
 	status = download_fw(edge_serial, fw);
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux