RE: [PATCH v2 RESEND 7/9] xhci: remove XHCI_TRUST_TX_LENGTH quirk and handle it as default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Mathias Nyman
> Now including Renesas uPD720201 we got four xhci vendors that return
> Success instead of short transfer when there are still unstraferred bytes
> left. The driver anyway checks the untransferred bytes and suggest adding
> the quirk if needed, so we can as well make it default behavior and get
> rid of the quirk all together.
...
> @@ -2114,14 +2114,13 @@ static int process_bulk_intr_td(struct xhci_hcd *xhci, struct xhci_td *td,
>  		/* Double check that the HW transferred everything. */
>  		if (event_trb != td->last_trb ||
>  		    EVENT_TRB_LEN(le32_to_cpu(event->transfer_len)) != 0) {
> -			xhci_warn(xhci, "WARN Successful completion "
> -					"on short TX\n");
> +			xhci_warn(xhci, "WARN Successful completion on short TX\n");

You really don't want to output that message at all.

Even with the old code it was very confusing because it looks like an
an issue with the xhci controller sending data.

	David

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux