On Wed, May 13, 2015 at 3:47 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Hello. > > On 05/13/2015 09:13 PM, Rodrigo Severo wrote: > >> Activating XHCI_TRUST_TX_LENGTH on Renesas uPD720201 USB 3.0 hosts to get >> rid of >> the following warnings when using webcams on this type of host: > > >> xhci_hcd 0000:06:00.0: WARN Successful completion on short TX: needs >> XHCI_TRUST_TX_LENGTH quirk? > > >> Signed-off-by: Rodrigo Severo <rodrigo@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/usb/host/xhci-pci.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) > > >> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c >> index b02641b..b25baa8 100644 >> --- a/drivers/usb/host/xhci-pci.c >> +++ b/drivers/usb/host/xhci-pci.c >> @@ -43,6 +43,7 @@ >> >> #define PCI_DEVICE_ID_ASMEDIA_ASM1042A 0x1142 >> >> +#define PCI_DEVICE_ID_RENESAS_UPD720201 0x0014 >> #define PCI_DEVICE_ID_RENESAS_UPD720202 0x0015 >> >> static const char hcd_name[] = "xhci_hcd"; >> @@ -173,13 +174,14 @@ static void xhci_pci_quirks(struct device *dev, >> struct xhci_hcd *xhci) >> xhci->quirks |= XHCI_TRUST_TX_LENGTH; >> } >> >> + if (pdev->vendor == PCI_VENDOR_ID_RENESAS && >> + (pdev->device == PCI_DEVICE_ID_RENESAS_UPD720201) >> || >> + pdev->device == PCI_DEVICE_ID_RENESAS_UPD720202)) > > > I'm seeing parenthesis mismatch, have you compiled this? I thought I did but obviously I didn't. I'm testing several USB hosts and got confused: used a prior kernel version and tested another board. No, 2 errors really don't make a right... After straighten my workflow I have already compiled it and am in the process of testing it. Will send the corrected patch as soon as I finish the proper tests. Sorry for the trouble and thanks for your review. Regards, Rodrigo Severo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
