On Thu, Apr 30, 2015 at 11:36:08AM +0200, Christoph Hellwig wrote: > On Thu, Apr 30, 2015 at 11:32:54AM +0200, Greg Kroah-Hartman wrote: > > We should not be doing assignments within an if () block > > so fix up the code to not do this. > > Any reason your ccing me on random cleanups on random usb crap? > > Nothing personal, but I'm getting tons of these weird cc lately, so I suspect > there's some automated tool behind it that needs fixing. scripts/get_maintainer.pl is bringing up your name for this file as you have modified it in the past: $ ./scripts/get_maintainer.pl 0005-USB-inode.c-move-assignment-out-of-if-block.patch Felipe Balbi <balbi@xxxxxx> (maintainer:USB GADGET/PERIPH...,commit_signer:8/18=44%) Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:USB SUBSYSTEM,commit_signer:2/18=11%,authored:1/18=6%) Al Viro <viro@xxxxxxxxxxxxxxxxxx> (commit_signer:9/18=50%,authored:5/18=28%) Peter Chen <peter.chen@xxxxxxxxxxxxx> (commit_signer:2/18=11%,authored:2/18=11%) Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> (commit_signer:2/18=11%) Christoph Hellwig <hch@xxxxxx> (authored:2/18=11%) Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> (authored:1/18=6%) linux-usb@xxxxxxxxxxxxxxx (open list:USB GADGET/PERIPH...) linux-kernel@xxxxxxxxxxxxxxx (open list) I should have knocked the % down some and not had it also bother you and Andrezej, sorry about that. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html