Re: [PATCH 1/1] usb: musb: dsps: fix build on i386 when COMPILE_TEST is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 03, 2015 at 10:14:14AM -0500, Felipe Balbi wrote:
> Hi Greg,
> 
> On Wed, Mar 25, 2015 at 02:18:37PM -0700, Tony Lindgren wrote:
> > Commit 3e457371f436 ("usb: musb: Fix fifo reads for dm816x with musb_dsps")
> > fixed a USB error on dm816x, but introduced a new build error on i386
> > when COMPILE_TEST is set:
> > 
> > drivers/usb/musb/musb_dsps.c: In function ‘dsps_read_fifo32’:
> > drivers/usb/musb/musb_dsps.c:624:3: error: implicit declaration of function
> > ‘readsl’ [-Werror=implicit-function-declaration]
> > readsl(fifo, dst, len >> 2);
> > 
> > Let's fix this by using ioread32_rep() instead of readsl() as that's
> > more portable.
> > 
> > Fixes: 3e457371f436 ("usb: musb: Fix fifo reads for dm816x with musb_dsps")
> > Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> > Cc: Bin Liu <binmlist@xxxxxxxxx>
> > Cc: Brian Hutchinson <b.hutchman@xxxxxxxxx>
> > Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
> Can you apply this one directly ? It fixes a build error on i386.
> 
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>

Now queued up, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux