Hi Greg,
On Wed, Mar 25, 2015 at 02:18:37PM -0700, Tony Lindgren wrote:
> Commit 3e457371f436 ("usb: musb: Fix fifo reads for dm816x with musb_dsps")
> fixed a USB error on dm816x, but introduced a new build error on i386
> when COMPILE_TEST is set:
>
> drivers/usb/musb/musb_dsps.c: In function ‘dsps_read_fifo32’:
> drivers/usb/musb/musb_dsps.c:624:3: error: implicit declaration of function
> ‘readsl’ [-Werror=implicit-function-declaration]
> readsl(fifo, dst, len >> 2);
>
> Let's fix this by using ioread32_rep() instead of readsl() as that's
> more portable.
>
> Fixes: 3e457371f436 ("usb: musb: Fix fifo reads for dm816x with musb_dsps")
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Cc: Bin Liu <binmlist@xxxxxxxxx>
> Cc: Brian Hutchinson <b.hutchman@xxxxxxxxx>
> Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
Can you apply this one directly ? It fixes a build error on i386.
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
> drivers/usb/musb/musb_dsps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index 2c0750e..8e089c1 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -661,7 +661,7 @@ static void dsps_read_fifo32(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
> void __iomem *fifo = hw_ep->fifo;
>
> if (len >= 4) {
> - readsl(fifo, dst, len >> 2);
> + ioread32_rep(fifo, dst, len >> 2);
> dst += len & ~0x03;
> len &= 0x03;
> }
> --
> 2.1.4
>
--
balbi
Attachment:
signature.asc
Description: Digital signature
