Felipe, > -----Original Message----- > From: Balbi, Felipe > Sent: Tuesday, March 24, 2015 11:33 AM > To: Liu, Bin > Cc: Balbi, Felipe; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] usb: musb: do not backup/restore registers in runtime PM > callbacks > > On Mon, Mar 23, 2015 at 08:40:58PM -0500, Liu, Bin wrote: > > Felipe, > > > > > -----Original Message----- > > > From: Balbi, Felipe > > > Sent: Monday, March 23, 2015 7:37 PM > > > To: Liu, Bin > > > Cc: linux-usb@xxxxxxxxxxxxxxx; Balbi, Felipe > > > Subject: Re: [PATCH] usb: musb: do not backup/restore registers in > > > runtime PM callbacks > > > > > > On Mon, Mar 23, 2015 at 04:52:54PM -0500, Bin Liu wrote: > > > > The MUSB controller does not lost power during runtime > > > > suspend/resume, so unnecessary to backup/restore its registers. > > > > > > > > Signed-off-by: Bin Liu <b-liu@xxxxxx> > > > > > > are you sure this is true for *all* users of musb ? > > > > Well, I am not 100% sure, so posted this patch for comments ;) > > > > I checked MUSB only lost power during system suspend, in which case > > musb_suspend/resume() are already called to backup/resume MUSB registers. > > bus this is only true for AM335x devices. OMAP3/4 have been doing off-while- > idle for years :-) Yeah, I just read Hema HK's patch which originally added this context save/restore, and feel uncomfortable with my change either. Let's drop this patch, I am trying to find a different way to solve my problem, and having a good progress right now. Thanks, -Bin. > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
