Re: [PATCH] usb: musb: do not backup/restore registers in runtime PM callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 23, 2015 at 08:40:58PM -0500, Liu, Bin wrote:
> Felipe,
> 
> > -----Original Message-----
> > From: Balbi, Felipe
> > Sent: Monday, March 23, 2015 7:37 PM
> > To: Liu, Bin
> > Cc: linux-usb@xxxxxxxxxxxxxxx; Balbi, Felipe
> > Subject: Re: [PATCH] usb: musb: do not backup/restore registers in runtime PM
> > callbacks
> > 
> > On Mon, Mar 23, 2015 at 04:52:54PM -0500, Bin Liu wrote:
> > > The MUSB controller does not lost power during runtime suspend/resume,
> > > so unnecessary to backup/restore its registers.
> > >
> > > Signed-off-by: Bin Liu <b-liu@xxxxxx>
> > 
> > are you sure this is true for *all* users of musb ?
> 
> Well, I am not 100% sure, so posted this patch for comments ;)
> 
> I checked MUSB only lost power during system suspend, in which case
>  musb_suspend/resume() are already called to backup/resume MUSB registers.

bus this is only true for AM335x devices. OMAP3/4 have been doing
off-while-idle for years :-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux