Oliver Neukum <oneukum@xxxxxxx> writes: > This makes sure the error handling path is the same for > all error conditions, thus reducing code duplication. Great! This looks like I nice cleanup. Will test it out. Just a quick comment based on the first glance: > outnl: > return rv < 0 ? rv : count; How about changing the single remaining error without any rewinding into a direct "return -ENOMEM", and then drop the "outnl" label and simplify this to "return count"? Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html