On Wed, Mar 18, 2015 at 05:46:44PM +0300, Sergei Shtylyov wrote: > Hello. > > On 3/18/2015 3:40 PM, Heikki Krogerus wrote: > > >ULPI PHYs need to be bound to their controllers with a > >lookup. This adds helpers that the ULPI drivers can use to > >do both, the registration of the PHY and the lookup, at the > >same time. > > >Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > >Cc: Kishon Vijay Abraham I <kishon@xxxxxx> > >--- > > drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 drivers/phy/ulpi_phy.h > > >diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h > >new file mode 100644 > >index 0000000..ac49fb6 > >--- /dev/null > >+++ b/drivers/phy/ulpi_phy.h > >@@ -0,0 +1,31 @@ > >+#include <linux/phy/phy.h> > >+ > >+/** > >+ * Helper that registers PHY for a ULPI device and adds a lookup for binding it > >+ * and it's controller, which is always the parent. > >+ */ > >+static inline struct phy > >+*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops) > > Please either keep the prototype on a single line or don't break it like > this. The result type should be all on the 1st line. IMHO this is quite fine and readable. We can find this style in many places of the kernel. Maybe it's a matter of taste :) BR, David > > [...] > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
