> -----Original Message----- > From: John Youn [mailto:John.Youn@xxxxxxxxxxxx] > Sent: Monday, March 16, 2015 6:31 PM > To: Kaukab, Yousaf; 'balbi@xxxxxx'; John Youn > Cc: linux-usb@xxxxxxxxxxxxxxx; Herrero, Gregory; r.baldyga@xxxxxxxxxxx; > dinguyen@xxxxxxxxxxxxxxxxxxxxx; zhangfei.gao@xxxxxxxxxx > Subject: Re: [PATCH 01/19] usb: dwc2: move debugfs code to a separate file > > On 3/16/2015 6:43 AM, Kaukab, Yousaf wrote: > > > >> -----Original Message----- > >> From: Felipe Balbi [mailto:balbi@xxxxxx] > >> Sent: Saturday, March 14, 2015 6:11 PM > >> To: John Youn > >> Cc: Kaukab, Yousaf; linux-usb@xxxxxxxxxxxxxxx; balbi@xxxxxx; Herrero, > >> Gregory; r.baldyga@xxxxxxxxxxx; dinguyen@xxxxxxxxxxxxxxxxxxxxx; > >> zhangfei.gao@xxxxxxxxxx > >> Subject: Re: [PATCH 01/19] usb: dwc2: move debugfs code to a separate > >> file > >> > >> On Mon, Mar 09, 2015 at 06:42:36PM -0700, John Youn wrote: > >>> On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote: > >>>> + > >>>> +int dwc2_debugfs_init(struct dwc2_hsotg *hsotg) { > >>>> + int ret; > >>>> + > >>>> + hsotg->debug_root = debugfs_create_dir(dev_name(hsotg- > >>> dev), NULL); > >>>> + if (!hsotg->debug_root) { > >>>> + ret = -ENOMEM; > >>>> + goto err0; > >>>> + } > >>>> + > >>>> + /* Add gadget debugfs nodes */ > >>>> + s3c_hsotg_create_debug(hsotg); > >>>> +err0: > >>>> + return ret; > >>>> +} > >>> > >>> Need export for this function when dwc2-platform is configured as a > module. > >> > >> the file is still part of the same binary, right ? EXPORT_SYMBOL*() > >> are only needed when functions are exposed to other modules. Usually, > >> EXPORT_SYMBOL*() in a driver (not in the framework) is an indication > >> that something's wrong ;-) > > > > EXPORT_SYMBOL* are needed because the driver is built as three different > modules dwc2.ko dwc2_platform.ko and dwc2_pci.ko. > > As dwc2_pci is now exporting platform device as well, we can get rid > > of all EXPORT_SYMBOLS* by having only two modules dwc2.ko and > > dwc2_pci.ko. That is by including platform.o in dwc2.ko > > > > I will include the missing EXPORT_SYMBOLS* in this patch. > > > > I have another patch read to merge dwc2.ko and dwc2_platform.ko and > remove all EXPORT_SYMBOLS*. If John agrees, then I can include this in the > next revision of this patch-set. > > Yes that would be great if you could do that. Ok I will include it in the next patch-set revision. Which, hopefully, I will send out in a couple of day. > > Thanks, > John > BR, Yousaf ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
