On Mon, Mar 09, 2015 at 06:42:36PM -0700, John Youn wrote: > On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote: > > + > > +int dwc2_debugfs_init(struct dwc2_hsotg *hsotg) > > +{ > > + int ret; > > + > > + hsotg->debug_root = debugfs_create_dir(dev_name(hsotg->dev), NULL); > > + if (!hsotg->debug_root) { > > + ret = -ENOMEM; > > + goto err0; > > + } > > + > > + /* Add gadget debugfs nodes */ > > + s3c_hsotg_create_debug(hsotg); > > +err0: > > + return ret; > > +} > > Need export for this function when dwc2-platform is configured as a module. the file is still part of the same binary, right ? EXPORT_SYMBOL*() are only needed when functions are exposed to other modules. Usually, EXPORT_SYMBOL*() in a driver (not in the framework) is an indication that something's wrong ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature