On Wed, Mar 11, 2015 at 04:05:31PM +0100, Bas Vermeulen wrote: > > On Wed, March 11, 2015 4:01 pm, Sascha Hauer wrote: > > On Wed, Mar 11, 2015 at 03:52:53PM +0100, Bas Vermeulen wrote: > >> Hello, > >> > >> On Wed, March 11, 2015 2:51 pm, Sascha Hauer wrote: > >> > This driver normally is not used with device tree. Without additional > >> > kernel changes the chipidea driver is used instead. > >> > >> I'm just forward-porting a patch I made for 2.6.31.14 to workaround > >> an issue we found. I'm unsure where to fit this in in the chipidea > >> driver. > >> > >> However, if you read the errata for the i.mx35, you will see the problem > >> and the fix proposed. I have been unable to find that errata for other > >> soc's in the family (but some google fu found somewhat similar issues > >> for > >> i.mx25 and i.mx51). > >> > >> I would still like to get this patch incorporated into the ehci-mxc > >> driver, as it might make it easier to find for people with the same > >> problem. > > > > If you start your board with device tree the ehci-mxc driver will never > > be started, because noone ever registers the device. When you start > > without device tree (but instead with board file) > > of_machine_is_compatible("fsl,imx35") will always return false because > > there is no device tree. To trigger your fixup one would have to start > > the kernel via device tree and additionally create a board file which > > registers the ehci-mxc device. A rather unusual case. > > What should I use instead? I'm fine changing the patch, I'm just not sure > what to use to make it conditional. A question is whether it should be conditional at all. We are currently hunting a very hard to trigger bug on the i.MX53 which could be this one. We are testing it and Michael will can send a (tested) patch later. However, this will probably take some weeks because as said the bugs takes very long to trigger. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html