On Tue, Mar 10, 2015 at 03:46:31PM -0500, Felipe Balbi wrote: > On Mon, Mar 09, 2015 at 10:09:21AM +0800, Li Jun wrote: > > From: Li Jun <b47624@xxxxxxxxxxxxx> > > > > Add a dedicataed normal timer for HNP polling since it's cyclical, while > > in peripheral mode, change a/b_bus_req to be 1 will make it response > > to host request flag with 1, then role switch will be started. > > > > Signed-off-by: Li Jun <jun.li@xxxxxxxxxxxxx> > > I don't get why you have so much code hidden away in a single > controller. You should really add this timer much more generically so > that there's no change needed on chipidea/musb/dwc2/dwc3/etc. > Accept, I will move those stuff out of controller driver and put it in common/usb-otg-fsm.c, then it can be used for different controllers w/o change needed. Li Jun > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
