Re: [PATCH 5/7] usb: chipidea: otg_fsm: add HNP polling support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 09, 2015 at 10:09:21AM +0800, Li Jun wrote:
> From: Li Jun <b47624@xxxxxxxxxxxxx>
> 
> Add a dedicataed normal timer for HNP polling since it's cyclical, while
> in peripheral mode, change a/b_bus_req to be 1 will make it response
> to host request flag with 1, then role switch will be started.
> 
> Signed-off-by: Li Jun <jun.li@xxxxxxxxxxxxx>

I don't get why you have so much code hidden away in a single
controller. You should really add this timer much more generically so
that there's no change needed on chipidea/musb/dwc2/dwc3/etc.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux