Re: [PATCH 7/7] usb: musb: dsps: remove babble check from dsps irq handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 26, 2015 at 09:18:04AM -0600, Bin Liu wrote:
> Felipe,
> 
> On Thu, Feb 26, 2015 at 9:07 AM, Felipe Balbi <balbi@xxxxxx> wrote:
> > musb->int_usb already contains the correct
> > information for musb-core to handle babble.
> >
> > In fact, this very check was just causing a
> > nonsensical babble interrupt storm because.
> 
> because of what?

because of that extra disconnect interrupt. As soon as I removed this,
the irq storm and unhandled disconnect stopped. Plus, the bit shifts
match exactly what we see on original musb registers, so we might as
well leave musb core handle it by just passing around int_usb to it.

Remember that the only thing that's am335x-specific is the ability to
reset the IP :-) MUSB core already had knowledge of babble.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux