Re: [PATCH 3/7] usb: musb: core: move babble recovery inside babble check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe,

On Thu, Feb 26, 2015 at 9:07 AM, Felipe Balbi <balbi@xxxxxx> wrote:
> There was already a proper place where we were
> checking for babble interrupts, move babble
> recovery there.

I commented on the same before, discussed in [1].

[1]: http://marc.info/?l=linux-usb&m=140109400304196&w=2


>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>  drivers/usb/musb/musb_core.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 2767ce1bf016..0569b24719e6 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -892,6 +892,12 @@ b_host:
>                         } else {
>                                 ERR("Stopping host session -- babble\n");
>                                 musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> +
> +                               if (is_host_active(musb)) {
> +                                       musb_generic_disable(musb);
> +                                       schedule_delayed_work(&musb->recover_work,
> +                                                       msecs_to_jiffies(100));
> +                               }
>                         }
>                 } else {
>                         dev_dbg(musb->controller, "BUS RESET as %s\n",
> @@ -931,13 +937,6 @@ b_host:
>                 }
>         }
>
> -       /* handle babble condition */
> -       if (int_usb & MUSB_INTR_BABBLE && is_host_active(musb)) {
> -               musb_generic_disable(musb);
> -               schedule_delayed_work(&musb->recover_work,
> -                                     msecs_to_jiffies(100));
> -       }
> -
>  #if 0
>  /* REVISIT ... this would be for multiplexing periodic endpoints, or
>   * supporting transfer phasing to prevent exceeding ISO bandwidth
> --
> 2.3.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux