Re: [PATCH] usb: isp1760: fix peripheral/device controller chip id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On 25/02/15 22:27, Laurent Pinchart wrote:
Hi Sudeep,

Thank you for the patch.

On Tuesday 24 February 2015 17:53:42 Sudeep Holla wrote:
As per the ISP1761 data sheet, the DcChipID register represents
the hardware version number (0015h) and the chip ID (8210h) for the
Peripheral Controller.

This patch fixes the chip ID value used to verify the controller.

Cc: Felipe Balbi <balbi@xxxxxx>
Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
---
  drivers/usb/isp1760/isp1760-udc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Laurent,

I found that the chip ID is wrong when I tried testing OTG on vexpress
platforms. As per Section 10.8.2 DcChipID register in [1], it should be
0x00158210.

On the other hand, http://www.nxp.com/documents/data_sheet/SAF1761.pdf#120
uses 0x00011582. It looks like we need to accept both.


Thanks for sharing this datasheet, I will update to accept both ID and
resend.

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux