Hi Sudeep, Thank you for the patch. On Tuesday 24 February 2015 17:53:42 Sudeep Holla wrote: > As per the ISP1761 data sheet, the DcChipID register represents > the hardware version number (0015h) and the chip ID (8210h) for the > Peripheral Controller. > > This patch fixes the chip ID value used to verify the controller. > > Cc: Felipe Balbi <balbi@xxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx> > --- > drivers/usb/isp1760/isp1760-udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Laurent, > > I found that the chip ID is wrong when I tried testing OTG on vexpress > platforms. As per Section 10.8.2 DcChipID register in [1], it should be > 0x00158210. On the other hand, http://www.nxp.com/documents/data_sheet/SAF1761.pdf#120 uses 0x00011582. It looks like we need to accept both. > It's still not functional, I will follow up with the logs separately. > > Regards, > Sudeep > [1] > http://ridl.cfd.rit.edu/products/manuals/Altera/DE3_v.1.7_CDROM/Datasheet/U > SB/ISP1761.pdf#G2148521 > > diff --git a/drivers/usb/isp1760/isp1760-udc.c > b/drivers/usb/isp1760/isp1760-udc.c index 9612d7990565..87a8dc044fce 100644 > --- a/drivers/usb/isp1760/isp1760-udc.c > +++ b/drivers/usb/isp1760/isp1760-udc.c > @@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc) > return -ENODEV; > } > > - if (chipid != 0x00011582) { > + if (chipid != 0x00158210) { > dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid); > return -ENODEV; > } -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
