On Wed, Feb 18, 2015 at 07:05:41PM -0000, Karl Palsson wrote: > I've already got most of this working in my branch overhauling this > driver. I agree, the open call shouldn't be doing all the hard > resetting of settings that it currently does. I've implemented more of > set termios / get termios. > > It's not ready for submission yet, I've got a lot of debug added that > needs to be rebased and squished out, and I still want to do more > testing with hardware flow control and the rest of the modem status > lines. > > https://github.com/karlp/linux/commits/ch341-3.18.6 > > By implementing proper reading of settings from the device, a lot of the > private copies can just be dropped out altogether. Yes, there shouldn't be a need to store the baud rate in the driver (the tty layer will keep track of that), but you probably still want to store the state of the modem-control signals. Looks like we could get rid of that ch341_configure at every open too? Looking forward to seeing your patches when you're done. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
