On Sat, Feb 14, 2015 at 05:46:05PM +0200, Laurent Pinchart wrote: > Hi Felipe, > > Thank you for the patch. > > On Friday 13 February 2015 15:07:54 Felipe Balbi wrote: > > Make sure we're using the new macro, so our > > resume signaling will always pass certification. > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > drivers/usb/dwc2/hcd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > > index c78c8740db1d..758b7e0380f6 100644 > > --- a/drivers/usb/dwc2/hcd.c > > +++ b/drivers/usb/dwc2/hcd.c > > @@ -1521,7 +1521,7 @@ static int dwc2_hcd_hub_control(struct dwc2_hsotg > > *hsotg, u16 typereq, dev_dbg(hsotg->dev, > > "ClearPortFeature USB_PORT_FEAT_SUSPEND\n"); > > writel(0, hsotg->regs + PCGCTL); > > - usleep_range(20000, 40000); > > + msleep(USB_RESUME_TIMEOUT); > > In order not to increase the number of wake events, shouldn't we use > usleep_range() at least for drivers that already use it ? we shouldn't use usleep_range() for anything larger than 10ms anyway. -- balbi
Attachment:
signature.asc
Description: Digital signature
