Fabio Estevam <festevam@xxxxxxxxx> writes: > On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: >> All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional >> and not prevent the driver from working. Fix the regression in the >> behavior introduced by commit "usb: phy: generic: migrate to gpio_desc". > > The usual way is to also specify the commit number. Yes, if it's already upstream in Linus's tree, where it's not. When Linus will pull, the commit id will change, and the commit message will become wrong, that's why I omitted the commit id. > >> + if (nop->gpiod_reset) >> + gpiod_direction_output(nop->gpiod_reset, 0); > > If you change it to: > gpiod_direction_output(nop->gpiod_reset, 1); > > then you can add: > > Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> Thanks, on my way. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
