Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:
> All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional
> and not prevent the driver from working. Fix the regression in the
> behavior introduced by commit "usb: phy: generic: migrate to gpio_desc".

The usual way is to also specify the commit number.


> +       if (nop->gpiod_reset)
> +               gpiod_direction_output(nop->gpiod_reset, 0);

If you change it to:
gpiod_direction_output(nop->gpiod_reset, 1);

then you can add:

Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux