On Wed, Jan 28, 2015 at 08:04:20PM +0100, Robert Jarzmik wrote: > Felipe Balbi <balbi@xxxxxx> writes: > > >> > At the same time, declare the interrupt as "one shot" so that it is > >> > masked until the end of the threaded handler. This prevents the irq core > >> > from spitting out an error : > >> > "Threaded irq requested with handler=NULL and !ONESHOT for irq 63" > >> > >> Shouldn't this be a separate patch? > >> > #define VBUS_IRQ_FLAGS \ > >> > - (IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING) > >> > + (IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | \ > >> > + IRQF_ONESHOT) > >> > >> IMHO, unrelated to the regression fix. > > > > +1 > Sure, no problem. > As soon as there is a confirmation of the right final fix for the direction > issue, I'll post a V2 with 2 patches instead of 1. thanks for keeping up with this ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
