On Wed, Jan 28, 2015 at 10:21:11AM -0800, Sören Brinkmann wrote: > On Wed, 2015-01-28 at 09:29AM +0100, Robert Jarzmik wrote: > > All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional > > and not prevent the driver from working. Fix the regression in the > > behavior introduced by commit "usb: phy: generic: migrate to gpio_desc". > > > > At the same time, declare the interrupt as "one shot" so that it is > > masked until the end of the threaded handler. This prevents the irq core > > from spitting out an error : > > "Threaded irq requested with handler=NULL and !ONESHOT for irq 63" > > Shouldn't this be a separate patch? > > > > > Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> > > --- > > drivers/usb/phy/phy-generic.c | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c > > index 9a826ff..49db411 100644 > > --- a/drivers/usb/phy/phy-generic.c > > +++ b/drivers/usb/phy/phy-generic.c > > @@ -41,7 +41,8 @@ > > #include "phy-generic.h" > > > > #define VBUS_IRQ_FLAGS \ > > - (IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING) > > + (IRQF_SHARED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | \ > > + IRQF_ONESHOT) > > IMHO, unrelated to the regression fix. +1 -- balbi
Attachment:
signature.asc
Description: Digital signature
