Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 Jan 2015, Andy Shevchenko wrote:

> On Tue, 2015-01-27 at 11:21 -0500, Alan Stern wrote:
> > On Tue, 27 Jan 2015, Peter Chen wrote:
> > 
> > > > > > Please fix this properly.
> > > > > 
> > > > > I don't know the right way to fix this. Alan, has you any suggestion?
> > > > 
> > > > It depends.  How did the code before the adfa79d1c06a commit avoid this
> > > > problem?  By simply not enabling CONFIG_USB_EHCI_HCD?
> > > > 
> > > 
> > > Hi Andy, Would you define pci_id at ci_hdrc_pci.c (instead of ehci-pci.c)
> > > at your platform code/table to fix this problem?
> > > I am not familiar with pci, but it works at other platforms, like ARM.
> > 
> > You can't remove the definition of pci_id in ehci-pci.c; if you did 
> > then ehci-pci wouldn't bind to PCI controllers.
> > 
> > It may turn out that the best way to fix this is to include a quirk in 
> > ehci-pci.c to prevent it from binding to the Intel MID on-board EHCI 
> > controller.
> 
> That was one of my thoughts. I would do that way.

Then go ahead and write a patch to do this.

> Regarding to the initial issue, it was along time ago, and I totally
> forgot what we do to make it working. Thus, it possible that the split
> does nothing with the problem.

If you don't know that the adfa79d1c06a commit caused the problem then 
your Changelog shouldn't claim that it did.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux