Hi Robert, On Tue, Jan 27, 2015 at 8:35 AM, <robert.jarzmik@xxxxxxx> wrote: > ----- Mail original ----- > De: "Fabio Estevam" <festevam@xxxxxxxxx> > À: "Robert Jarzmik" <robert.jarzmik@xxxxxxx> > Cc: "Felipe Balbi" <balbi@xxxxxx>, "Linus Walleij" <linus.walleij@xxxxxxxxxx>, "Philipp Zabel" <philipp.zabel@xxxxxxxxx>, "USB list" <linux-usb@xxxxxxxxxxxxxxx> > Envoyé: Mardi 27 Janvier 2015 10:40:35 > Objet: Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc >> - nop->gpiod_reset = devm_gpiod_get(dev, "reset-gpios"); >> + nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset-gpios"); > >> According to Documentation/gpio/board.txt: > >> "GPIOs mappings are defined in the consumer device's node, in a >> property named <function>-gpios" >> so this should be: >> nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset"); > Ah you're right, I see it now ... in of_find_gpio(), the match is done on "%s-%s", where > the first one is the string in devm_gpiod_get(), and the second one is either "gpio" or > "gpios" ... > > I'll amend my patch just as you said, my bad. but the problem I see is that even if I use: nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset"); The 'reset-gpio' pin cannot be retrieved. This is the point I don't understand currently. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
