Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 26 Jan 2015, Andy Shevchenko wrote:

> On Mon, 2015-01-26 at 09:21 -0800, Greg KH wrote:
> > On Mon, Jan 26, 2015 at 07:10:42PM +0200, Andy Shevchenko wrote:
> > > On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI
> > > is in conflict with the proper driver. The patch makes a quick fix to get Intel
> > > Medfield platforms work back.
> > > 
> > > One would make a proper patch to address the issue.
> > 
> > Who is "one"?  You?  Someone else?
> 
> Not me.
> 
> > 
> > > Fixes: adfa79d1c06a (USB: EHCI: make ehci-pci a separate driver)
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/usb/host/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > > index fafc628..32d735a 100644
> > > --- a/drivers/usb/host/Kconfig
> > > +++ b/drivers/usb/host/Kconfig
> > > @@ -112,7 +112,7 @@ if USB_EHCI_HCD
> > >  
> > >  config USB_EHCI_PCI
> > >  	tristate
> > > -	depends on PCI
> > > +	depends on PCI && !X86_INTEL_MID
> > 
> > You just broke making a universal kernel build for your platform
> > possible, making distro developers very upset with you.
> 
> I agree, though current kernel build doesn't work on the Intel MID
> anyway (I mean USB support). The mentioned commit broke it and seems
> no-one cared until now.
> 
> > Please fix this properly.
> 
> I don't know the right way to fix this. Alan, has you any suggestion?

It depends.  How did the code before the adfa79d1c06a commit avoid this
problem?  By simply not enabling CONFIG_USB_EHCI_HCD?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux