Hello.
On 01/18/2015 01:49 AM, Sylvain Rochet wrote:
There's little inconsistency in your patch subjects: you're using
'_' but the files you're modifying are named using '-'...
Indeed.
@@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = {
.probe = ehci_atmel_drv_probe,
.remove = ehci_atmel_drv_remove,
.shutdown = usb_hcd_platform_shutdown,
+ .suspend = ehci_atmel_drv_suspend,
+ .resume = ehci_atmel_drv_resume,
I think you should use 'struct dev_pm_ops' now.
I'm not sure but perhaps scripts/checkpatch.pl would complain about the
old-style PM methods... should check.
This way ?
static int ehci_atmel_drv_suspend(struct device *dev)
{
struct usb_hcd *hcd = dev_get_drvdata(dev);
(...)
static SIMPLE_DEV_PM_OPS(ehci_atmel_pm_ops, ehci_atmel_drv_suspend, ehci_atmel_drv_resume);
(...)
.driver = {
.pm = &ehci_atmel_pm_ops,
}
(...)
Yes, probably.
Should I send a v4 or can I send this change separately on top of the
previous change ?
v4 please.
Sylvain
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
