Hi Sergei,
On Sun, Jan 18, 2015 at 01:22:38AM +0300, Sergei Shtylyov wrote:
>
> There's little inconsistency in your patch subjects: you're using
> '_' but the files you're modifying are named using '-'...
Indeed.
> >@@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = {
> > .probe = ehci_atmel_drv_probe,
> > .remove = ehci_atmel_drv_remove,
> > .shutdown = usb_hcd_platform_shutdown,
> >+ .suspend = ehci_atmel_drv_suspend,
> >+ .resume = ehci_atmel_drv_resume,
>
> I think you should use 'struct dev_pm_ops' now.
This way ?
static int ehci_atmel_drv_suspend(struct device *dev)
{
struct usb_hcd *hcd = dev_get_drvdata(dev);
(...)
static SIMPLE_DEV_PM_OPS(ehci_atmel_pm_ops, ehci_atmel_drv_suspend, ehci_atmel_drv_resume);
(...)
.driver = {
.pm = &ehci_atmel_pm_ops,
}
(...)
Should I send a v4 or can I send this change separately on top of the
previous change ?
Sylvain
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
