On Mon, 12 Jan 2015 13:31:26 -0600 Felipe Balbi <balbi@xxxxxx> wrote: > On Mon, Jan 12, 2015 at 08:18:16PM +0100, Boris Brezillon wrote: > > Hi Felipe, > > > > On Mon, 12 Jan 2015 12:23:49 -0600 > > Felipe Balbi <balbi@xxxxxx> wrote: > > > > > On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote: > > > > at91sam9g45, at91sam9x5 and sama5 SoCs should not use > > > > "atmel,at91sam9rl-udc" for their USB device compatible property since > > > > this compatible is attached to a specific hardware bug fix. > > > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > > > > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > > > > > > WARNING: DT compatible string "atmel,at91sam9g45-udc" appears un-documented -- check ./Documentation/devicetree/bindings/ > > > #177: FILE: drivers/usb/gadget/udc/atmel_usba_udc.c:1827: > > > + { .compatible = "atmel,at91sam9g45-udc" }, > > > > > > WARNING: DT compatible string "atmel,sama5d3-udc" appears un-documented -- check ./Documentation/devicetree/bindings/ > > > #178: FILE: drivers/usb/gadget/udc/atmel_usba_udc.c:1828: > > > + { .compatible = "atmel,sama5d3-udc" }, > > > > > > please fix and resend. Also, when resending, could you add Nicolas' > > > Acked-by since he's already given it ? > > > > Actually these compatible strings are documented in the first patch > > (where they were introduced), but I'll send a v4 with Nicolas' ack. > > heh, checkpatch stupidity :-) My bad. > You took v3 of the first patch instead of v4. Don't know if you can replace it (anyway, that's not such a big deal since the only change is the commit message)... -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html