On Sat, 2014-11-29 at 15:48 +0300, Dan Carpenter wrote: > The "fmt" variable might be used uninitialized, it should be set to NULL > at the start. > > Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Hm, that' falls into the category of an interface that's hard to get right if every caller has to remember to set fmt to NULL. Could you instead set *fmt to NULL in scsi_extd_sense_format()? That way the interface is much easier. Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html