Re: [PATCH] usb: gadget: zero: fix INT endpoint assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Sebastian,

On 11/25/2014 10:56 PM, Sebastian Andrzej Siewior wrote:
This fixes the test case mentioned for musb which is a regression.
Other things that I noticed:

- if ISOC is not available, we won't have INT as well.

I didn't understand this. The original patch added a new alternate setting (2) that has two interrupt endpoints. ISOC EP is available through alternate setting 1.

- wMaxPacketSize is supposed to be LE. The assignments within the code
   does not use cpu_to_le16().

Can you please point to the code where it should have been and is missing?

- the module Parameter for INT says max packet size is 0…1023 for FS.

Yes, I'll send a patch to rectify this.

   This is clearly a copy/paste bug.

Amit could you please look at this and fix it?

Sebastian


Regards
Amit Virdi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux