On Wed, Nov 05, 2014 at 10:57:46PM -0600, Felipe Balbi wrote: > On Thu, Nov 06, 2014 at 03:13:57AM +0000, Ben Hutchings wrote: > > On Wed, 2014-11-05 at 20:56 -0600, Felipe Balbi wrote: > > > On Thu, Nov 06, 2014 at 01:25:39AM +0000, Ben Hutchings wrote: > > > > A Kconfig choice only allows one 'y' selection or multiple 'm' > > > > selections, but it is valid to have any combination of 'y' and 'm' > > > > selections here (dependent on USB_MUSB_HDRC). Use a menu instead. > > > > > > > > Reported-by: Arnaud Patard <arnaud.patard@xxxxxxxxxxx> > > > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > > > > > > not yet. A kernel with TUSB6010=y and any other glue layer =y won't > > > work, IIRC it won't even build. How have you tested this patch ? > > > > Arnaud had a configuration for Debian where this was needed, and his > > patch removed the choice and endchoice. We didn't run into that > > incomapatibility. However, we don't currently use a mixture of 'y' and > > 'm', so I have to confess I haven't tested it. > > I'll run a few build tests here with this patch and see what comes out > of it. sorry for the delay, have been pretty busy with some other stuff. But as I suspected: drivers/usb/musb/tusb6010.o: In function `musb_read_fifo': drivers/usb/musb/tusb6010.c:227: multiple definition of `musb_read_fifo' drivers/usb/musb/am35x.o:drivers/usb/musb/am35x.c:412: first defined here make[3]: *** [drivers/usb/musb/built-in.o] Error 1 make[2]: *** [drivers/usb/musb] Error 2 make[1]: *** [drivers/usb] Error 2 make: *** [drivers] Error 2 -- balbi
Attachment:
signature.asc
Description: Digital signature
