Re: [PATCH] drivers/usb/musb/Kconfig: Use menu instead of choice for Platform Glue Layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 06, 2014 at 03:13:57AM +0000, Ben Hutchings wrote:
> On Wed, 2014-11-05 at 20:56 -0600, Felipe Balbi wrote:
> > On Thu, Nov 06, 2014 at 01:25:39AM +0000, Ben Hutchings wrote:
> > > A Kconfig choice only allows one 'y' selection or multiple 'm'
> > > selections, but it is valid to have any combination of 'y' and 'm'
> > > selections here (dependent on USB_MUSB_HDRC).  Use a menu instead.
> > > 
> > > Reported-by: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>
> > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > 
> > not yet. A kernel with TUSB6010=y and any other glue layer =y won't
> > work, IIRC it won't even build. How have you tested this patch ?
> 
> Arnaud had a configuration for Debian where this was needed, and his
> patch removed the choice and endchoice.  We didn't run into that
> incomapatibility.  However, we don't currently use a mixture of 'y' and
> 'm', so I have to confess I haven't tested it.

I'll run a few build tests here with this patch and see what comes out
of it.

cheers

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux