Re: [PATCH] usb: gagdet: f_midi: fix parameter assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 21, 2014 at 01:00:30AM +0100, Daniel Mack wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/20/2014 08:49 PM, Felipe Balbi wrote:
> > On Tue, Nov 18, 2014 at 11:21:17PM +0100, Daniel Mack wrote:
> >> f_midi_register_card() uses midi->id and midi->index, so they
> >> need to be assigned before the function is called from
> >> f_midi_bind_config(). Move the assigment of midi->buflen and
> >> midi->qlen as well so they are all grouped.
> >> 
> >> Compile tested only.
> >> 
> >> Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx>
> > 
> > doesn't apply:
> > 
> > checking file drivers/usb/gadget/function/f_midi.c Hunk #1 FAILED
> > at 954. Hunk #2 FAILED at 965. 2 out of 2 hunks FAILED
> > 
> > can you rebase on my testing/next ?
> 
> Ah, I thought for a fix like this, your 'fixes' branch is enough.
> 
> In your testing/next, the code looks quite different, and if I read
> that correctly, the bug is already fixed there. Guess you can just
> drop the patch then :)

very well, then :-)

cheers

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux