Re: [PATCH] usb: gagdet: f_midi: fix parameter assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/20/2014 08:49 PM, Felipe Balbi wrote:
> On Tue, Nov 18, 2014 at 11:21:17PM +0100, Daniel Mack wrote:
>> f_midi_register_card() uses midi->id and midi->index, so they
>> need to be assigned before the function is called from
>> f_midi_bind_config(). Move the assigment of midi->buflen and
>> midi->qlen as well so they are all grouped.
>> 
>> Compile tested only.
>> 
>> Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx>
> 
> doesn't apply:
> 
> checking file drivers/usb/gadget/function/f_midi.c Hunk #1 FAILED
> at 954. Hunk #2 FAILED at 965. 2 out of 2 hunks FAILED
> 
> can you rebase on my testing/next ?

Ah, I thought for a fix like this, your 'fixes' branch is enough.

In your testing/next, the code looks quite different, and if I read
that correctly, the bug is already fixed there. Guess you can just
drop the patch then :)


Thanks,
Daniel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUboCeAAoJELphMRr8Y1QkFD4QAKZB+gwXgEiEqueazfiSj/LP
WfVJiw09JcIBsupserd7ILYJyQXOuOEvBxAP/Jak0iOG1Vc8NaR1a4g3bDYGBEGU
PWd+8WkV45hj/tZbAJwoFp92gIvWyXIVYJZc2B/EqpT+eyq653zvuy2oQl3x5jpo
pc80eGBD3/DkzQEUe7U/lB05RnlOle+7+I0yOPg3W1X2Bc7OJFbSVekg5fiMCAee
wbmnYKDp7F923PQCs99zVNCS8o8c4lPuSZH4VSzJ5gyctLPcGv33O4ECPx3qYDWQ
L9iwgczD4UQ2yzxbXVwAi1yXUm120xE5ktdYO4Ry+d/VMP/dq22QNhy2e9SiydaQ
SBfen1bW7bs4+C7WUiv5TEKl2SXKdXes/TIqqii75YiNuv8L/GAJQ6KWYghIGZ+K
c9K4FHIpKsigRQtCOkd4finA1gaWYrGMarFXM7UlGoAJ2UuqLE1vm/LOj3I5lUhs
d0hUvGe6jegLRcCTnQj1nxc4ejf2RHKsM9H1TNcTN2LwSg0wrV+n5UM54vfVbZFy
hPVjEsV+XYdjGsWgycVNN+nHN4SUk91JSzFwtA7lPgvNasN/866ZCnx3bkJ1ThUJ
8+z19LKTPgOzVUjaobf6LEjeQKve48xLFrd0bYDB+orN6+SiI32jVfu+/dyFdMjr
5BErg/WaF+G3kdmVcq89
=P8sF
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux