Re: Patch for 3.18-rc4 to add OLIMEX ISP500 AVR Programmer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/11/14 08:27, Johan Hovold wrote:
On Wed, Nov 12, 2014 at 12:04:27AM +0000, Sid Boyce wrote:
On 11/11/14 19:46, Johan Hovold wrote:
On Tue, Nov 11, 2014 at 04:43:52PM +0000, Sid Boyce wrote:
Results
-----------
root@sdrbox:~# lsusb
Bus 002 Device 004: ID 13fd:1840 Initio Corporation INIC-1608 SATA bridge
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 003: ID 15ba:000c Olimex Ltd.

The failure due to AtMega32 not attached.
root@sdrbox:~# avrdude -p m32 -F -c stk500v2 -P /dev/ttyACM1

avrdude: stk500v2_command(): warning: Command timed out
avrdude: initialization failed, rc=-1
avrdude: AVR device initialized and ready to accept instructions
avrdude: Device signature = 0xc807c6
avrdude: Expected signature for ATmega32 is 1E 95 02

avrdude done.  Thank you.
I'm really not sure what I'm supposed to make of the above.

Care to submit the patch on a format that I can apply (i.e. with proper
subject and commit message and patch inline in body)? See
Documentation/SubmittingPatches for details.

Also why are you using an ACM node above? That's a different driver
(cdc-acm).

Could you provide "lsusb -v" output for your device as well?

Thanks,
Johan

root@sdrbox:~# lsusb
Bus 002 Device 004: ID 13fd:1840 Initio Corporation INIC-1608 SATA bridge
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 003: ID 15ba:000c Olimex Ltd.
Bus 004 Device 002: ID 195d:1009 Itron Technology iONE
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 001 Device 004: ID 2341:0043 Arduino SA Uno R3 (CDC ACM)
Bus 001 Device 003: ID 1a40:0101 Terminus Technology Inc. Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 002: ID 04f3:0103 Elan Microelectronics Corp. ActiveJet
K-2024 Multimedia Keyboard
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Can you use the verbose flag "-v", that is:

	lsusb -vd 15ba:000c

I have done another patch, please let me know if it needs a cleanup.
Lars raised very good point about the fact that you add an entry for a
different PID (0x000b).

When submitting patches, anything you write in the message body will end
up in the commit message (and the mail Subject becomes the commit
summary). If you need make any additional comments you put that below
the cut off line, but before the actual diff.

See

	http://marc.info/?l=linux-usb&m=141293474912256&w=2

for an example.

Check out "git format-patch" as well.

Thanks,
Johan

Thanks for the input and suggestions.
Still on a learning curve at submitting kernel patches.
Regards
Sid.

--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Senior Staff Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux