On Mon, Oct 27, 2014 at 05:56:27PM +0000, Karl Palsson wrote: > On Mon, Oct 27, 2014 at 06:34:33PM +0100, Johan Hovold wrote: > > Add device-id entry for GW Instek AFG-2225, which has a byte swapped > > bInterfaceSubClass (0x20). > > > > Reported-by: Karl Palsson <karlp@xxxxxxxxxxxx> > > Cc: stable <stable@xxxxxxxxxxxxxxx> > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx> > > --- > > > > Care to give this patch a try as well, Karl? You can respond with a > > Tested-by tag if you want. > > > > Not really setup for redoing kernels in the day job, but will see what I can > do tomorrow, as I'm getting a bit better at doing it at home now :) > > One thing, I see in the table of ids, that there's a NOT_A_MODEM define. > Is that something that should be set here too? Would it stop modem-manager > from insisting on trying to probe the device? I've gotten kind of used to > black listing modem manager from generic serial ports provied via usb, but > this is pretty clearly never going to be a modem. No, it only silences an error message during probe "This device cannot do calls on its own. It is not a modem." You should see that right? I guess we could use that quirk, but I'm actually leaning towards just removing that quirk and reducing the log level of the message to info. Oliver, what do you say? Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
