On Thu, 23 Oct 2014, Wonhong Kwon wrote: > ehci/ohci just define .suspend/.resume functions for dev_pm_ops, but > in order to support both STR(suspend-to-ram) and hibernation, other > callbacks such as .freeze/.thaw are also required. > > Registering all required callbacks for both STR and hibernation can > be done by SIMPLE_DEV_PM_OPS macro function. > > Signed-off-by: Wonhong Kwon <wonhong.kwon@xxxxxxx> The patch itself looks good, but the description and the title should be updated. The patch affects ehci_platform and ohci_platform, not ehci and ohci. If you fix that up, you can add: Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html