On Mon, Oct 20, 2014 at 08:45:02AM +0200, Robert Baldyga wrote: > Hi Felipe, > > On 10/17/2014 07:17 PM, Felipe Balbi wrote: > > now that no UDC driver relies on the extra > > 'driver' argument to ->udc_stop(), we can > > safely remove it. > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > I have already sent patch doing the same thing: > http://markmail.org/message/x5zneg4xea4zntab hmm... I had forgotten about that. If you can fix the bugs, I'll take your version. Look at what you do for mv_udc, for instance, this change: - stop_activity(udc, driver); + stop_activity(udc, udc->driver); Is completely bogus. What happens now is that this UDC driver will always pass a valid, non-NULL driver argument to stop_activity() which means that when the UDC is being stopped, it will call gadget driver's ->disconnect(). In fact, you did that blind change to all UDC drivers without considering what stop_activity() was really doing and when it was called. I guess I'll just note on my commit that it's based on your patch but with quite a few bugs being fixed. -- balbi
Attachment:
signature.asc
Description: Digital signature
