Re: [PATCH] storage: Fix timeout in usb_stor_euscsi_init() and usb_stor_huawei_e220_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 10/20/2014 10:34 PM, Mark Knibbs wrote:

...
   			0x0C, USB_RECIP_INTERFACE | USB_TYPE_VENDOR,
-			0x01, 0x0, us->iobuf, 0x1, 5000);
+			0x01, 0x0, us->iobuf, 0x1, 5*HZ);

     Pleas surround * with spaces, for consistency with the code above (and
thye general kernel coding style).

I noticed that spaces aren't used consistently. For example in
drivers/usb/storage/transport.c there are four instances of n*HZ. Also in
various files not in drivers/usb/

I assume it's not worth submitting a patch to only fix coding-style issues
like that?

   And you're right...
   ... unless scripts/checkpatch.pl reports them.

Mark

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux