> From: Sudip Mukherjee [mailto:sudipm.mukherjee@xxxxxxxxx] > Sent: Thursday, October 16, 2014 9:44 PM > > modified the function to have a single return statement at the end > instead of multiple return statement in the middle of the function > to improve the readability of the code. > > This patch depends on the previous patch of the series. > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > --- > drivers/usb/dwc2/gadget.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index 7f25527..e8a8fc7 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -2471,7 +2471,8 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, > dir_in = (desc->bEndpointAddress & USB_ENDPOINT_DIR_MASK) ? 1 : 0; > if (dir_in != hs_ep->dir_in) { > dev_err(hsotg->dev, "%s: direction mismatch!\n", __func__); > - return -EINVAL; > + ret = -EINVAL; > + goto error1; > } > > mps = usb_endpoint_maxp(desc); > @@ -2583,6 +2584,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, > > error: > spin_unlock_irqrestore(&hsotg->lock, flags); > +error1: > return ret; > } According to the discussion in another thread, let's drop this patch. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
