On Thu, Oct 16, 2014 at 08:22:08PM +0530, Sudip Mukherjee wrote: > On Thu, Oct 16, 2014 at 08:21:55AM -0500, Felipe Balbi wrote: > > HI, > > > > On Thu, Oct 16, 2014 at 01:11:10PM +0530, Sudip Mukherjee wrote: > > > sparse was giving the following warning: > > > warning: context imbalance in 's3c_hsotg_ep_enable' > > > - different lock contexts for basic block > > > > > > we were returning ENOMEM while still holding the spinlock. > > > The sparse warning was fixed by releasing the spinlock before return. > > > > > > This patch depends on the previous patch of the series. > > > > > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> > > > > this should be patch one so it can be backported to stable kernels. > > > my v1 patch fixed only this , while reviewing that one Paul Zimmerman > suggested to rewrite the return statements. > so this v2 series had the rewrite and the spinlock error fix. > now if this is to be made the patch one then it will be a duplicate of > my v1 followed by another patch for return statements. > should i do that ? Paul has the final word on this driver, if he already asked you to change, I withdraw my comment ;-) cheers -- balbi
Attachment:
signature.asc
Description: Digital signature
