Hi Johan,
2014-10-14 10:03 GMT+02:00 Johan Hovold <johan@xxxxxxxxxx>:
> On Tue, Oct 14, 2014 at 08:47:09AM +0200, Daniele Palmas wrote:
>> option driver, added VID/PID for Telit LE910 modem. Interfaces description
>> is almost the same than LE920, except that the qmi interface is number 2
>> (instead than 5).
>>
>> Signed-off-by: Daniele Palmas <dnlplm@xxxxxxxxx>
>> ---
>> drivers/usb/serial/option.c | 8 ++++++++
>> 1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index d1a3f60..0ed7626 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -269,6 +269,7 @@ static void option_instat_callback(struct urb *urb);
>> #define TELIT_PRODUCT_DE910_DUAL 0x1010
>> #define TELIT_PRODUCT_UE910_V2 0x1012
>> #define TELIT_PRODUCT_LE920 0x1200
>> +#define TELIT_PRODUCT_LE910 0x1201
>>
>> /* ZTE PRODUCTS */
>> #define ZTE_VENDOR_ID 0x19d2
>> @@ -594,6 +595,11 @@ static const struct option_blacklist_info telit_le920_blacklist = {
>> .reserved = BIT(1) | BIT(5),
>> };
>>
>> +static const struct option_blacklist_info telit_le910_blacklist = {
>> + .sendsetup = BIT(0),
>> + .reserved = BIT(1) | BIT(2),
>> +};
>> +
>> static const struct usb_device_id option_ids[] = {
>> { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },
>> { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
>> @@ -1140,6 +1146,8 @@ static const struct usb_device_id option_ids[] = {
>> { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_UE910_V2) },
>> { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE920),
>> .driver_info = (kernel_ulong_t)&telit_le920_blacklist },
>> + { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE910),
>> + .driver_info = (kernel_ulong_t)&telit_le910_blacklist },
>> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MF622, 0xff, 0xff, 0xff) }, /* ZTE WCDMA products */
>> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0002, 0xff, 0xff, 0xff),
>> .driver_info = (kernel_ulong_t)&net_intf1_blacklist },
>
> Looks good, but could you keep the blacklist info and device_id entries
> above sorted alphabetically? (The defines should be sorted by PID so no
> need to change that.)
>
Thanks for the review. I sent a V2 patch to address your remarks.
Regards,
Daniele
> Thanks,
> Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
