Re: [PATCH v2 2/3] USB: ohci-platform: Expose no_big_frame_no and num_ports in DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 14, 2014 at 6:58 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, 11 Oct 2014, Kevin Cernekee wrote:
>
>> These quirks are currently set through platform_data; allow DT-based SoCs
>> to use them too.
>>
>> Signed-off-by: Kevin Cernekee <cernekee@xxxxxxxxx>
>
>> --- a/drivers/usb/host/ohci-platform.c
>> +++ b/drivers/usb/host/ohci-platform.c
>> @@ -175,6 +175,12 @@ static int ohci_platform_probe(struct platform_device *dev)
>>               if (of_property_read_bool(dev->dev.of_node, "big-endian"))
>>                       ohci->flags |= OHCI_QUIRK_BE_MMIO | OHCI_QUIRK_BE_DESC;
>>
>> +             if (of_property_read_bool(dev->dev.of_node, "no-big-frame-no"))
>> +                     ohci->flags |= OHCI_QUIRK_FRAME_NO;
>> +
>> +             of_property_read_u32(dev->dev.of_node, "num-ports",
>> +                                  &ohci->num_ports);
>
> Does this do the right thing if the property isn't defined?

In that case, of_property_read_u32() will just return -EINVAL or
-ENODATA without writing anything to ohci->num_ports, leaving the
default of 0 in place.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux