Re: [PATCH v2 2/2] usb: chipidea: ci_hdrc_imx.c: Remove unneeded OOM message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 13, 2014 at 08:58:30AM -0300, Fabio Estevam wrote:
> MM core code already complains when devm_kzalloc() fails, so no need to print
> the error locally.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Add usb in the Subject
> 
>  drivers/usb/chipidea/ci_hdrc_imx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index a7ab0f1..74b5b09 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -115,10 +115,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
>  	const struct ci_hdrc_imx_platform_flag *imx_platform_flag = of_id->data;
>  
>  	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
> -	if (!data) {
> -		dev_err(&pdev->dev, "Failed to allocate ci_hdrc-imx data!\n");
> +	if (!data)
>  		return -ENOMEM;
> -	}
>  
>  	data->usbmisc_data = usbmisc_get_init_data(&pdev->dev);
>  	if (IS_ERR(data->usbmisc_data))
> -- 
> 1.9.1
> 

Both two have applied, thanks.

-- 
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux