On Mon, Oct 13, 2014 at 10:32:12AM -0500, Felipe Balbi wrote: > On Wed, Oct 08, 2014 at 02:12:18PM -0700, David Cohen wrote: > > The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the > > quirk implemented to align buffer size to maxpacketsize on out endpoint. > > As result, functionfs does not work on Intel platforms using dwc3 driver > > (i.e. Bay Trail and Merrifield). This patch fixes the issue. > > > > This code is based on a previous Qiuxu's patch. > > > > Fixes: 2e4c7553cd (usb: gadget: f_fs: add aio support) > > Cc: <stable@xxxxxxxxxxxxxxx> # v3.16+ > > Signed-off-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx> > > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx> > > Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> > > --- > > > > Hi, > > > > Since this is a feature that worked in past, this is meant for stable > > versions >= 3.16 too. > > > > v1 to v2: just added Fixes, Cc and Acked-by lines on patch description. > > this adds a build warning for use of maybe unitialized data_len. Plese > fix. It's a false-positive warning. data_len is only initialized if halt != 0 and it's only used if halt != 0 too. Do you prefer to initialize it to 0 during the declaration to silent the compiler? BR, David > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
