Re: [PATCH 1/2] chipidea: core: Remove unneeded OOM message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 12, 2014 at 11:26:33PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> MM core code already complains when devm_kzalloc() fails, so no need to print
> the error locally.
> 

For the title: you may need to add "usb" first. "usb: chipdea: xxx".
Besides, would you show me where the MM core code to do that?

> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
>  drivers/usb/chipidea/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 3df5005..c59929a 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -589,10 +589,8 @@ static int ci_hdrc_probe(struct platform_device *pdev)
>  		return PTR_ERR(base);
>  
>  	ci = devm_kzalloc(dev, sizeof(*ci), GFP_KERNEL);
> -	if (!ci) {
> -		dev_err(dev, "can't allocate device\n");
> +	if (!ci)
>  		return -ENOMEM;
> -	}
>  
>  	ci->dev = dev;
>  	ci->platdata = dev_get_platdata(dev);
> -- 
> 1.9.1
> 

-- 
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux